From 1b390c525d0034a3cef2b341966901fe08a9bdd6 Mon Sep 17 00:00:00 2001 From: Mamadou Babaei Date: Thu, 18 May 2023 22:36:20 +0200 Subject: [PATCH] temporarily disable the debug gizmo for the virtual hand and the wrist tracker due to an esoteric bug in the settings system --- CHANGELOG.md | 1 + .../SenseGlove/Components/SGVirtualHandComponent.cpp | 7 +++++-- .../SenseGlove/Components/SGWristTrackerComponent.cpp | 5 ++++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cf2f6865..ed05241a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ This release breaks ABI/API compatibility with the previous versions. ### Changed - SenseGlove libraries have been updated to v2.7.1-965f90c with support for Linux AArch64. +- The Virtual Hand and the Wrist Tracker debug Gizmos (the intended use is only for SenseGlove developers for really low-level stuff; thus won't affect the users of the plugin at all) have been disabled and will be ignored due to an esoteric bug in the settings systems which has been scheduled to be fixed in the future releases. ### Removed diff --git a/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp b/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp index ea2cc618..c6e735ff 100644 --- a/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp +++ b/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp @@ -750,8 +750,11 @@ void USGVirtualHandComponent::FImpl::DrawDebugVirtualHand() const const TArray>& JointPositions{HandPose->GetJointPositions()}; const TArray>& JointRotations{HandPose->GetJointRotations()}; - FSGDebugVirtualHand::Draw(World, WristLocation, WristRotation, JointPositions, JointRotations, - Owner->DebugVirtualHandSettings); + /// FIXME + /// We temporarily ignore the debug settings, as for an esoteric reason it always produces conditions, + /// in which the debug gizmo will be drawn! + //FSGDebugVirtualHand::Draw(World, WristLocation, WristRotation, JointPositions, JointRotations, + // Owner->DebugVirtualHandSettings); } void USGVirtualHandComponent::FImplDeleter::operator()(const FImpl* P) const diff --git a/Source/SenseGlove/Private/SenseGlove/Components/SGWristTrackerComponent.cpp b/Source/SenseGlove/Private/SenseGlove/Components/SGWristTrackerComponent.cpp index 1e336597..6fb6c5a4 100644 --- a/Source/SenseGlove/Private/SenseGlove/Components/SGWristTrackerComponent.cpp +++ b/Source/SenseGlove/Private/SenseGlove/Components/SGWristTrackerComponent.cpp @@ -539,7 +539,10 @@ void USGWristTrackerComponent::FImpl::DrawDebugGizmo() const FRotator& Rotation{Owner->GetComponentRotation()}; const FSGDebugGizmoSettings& DebugGizmoSettings{Owner->GetWristTrackerDebugGizmoSettings()}; - FSGDebugGizmo::Draw(World, Location, Rotation, DebugGizmoSettings); + /// FIXME + /// We temporarily ignore the debug settings, as for an esoteric reason it always produces conditions, + /// in which the debug gizmo will be drawn! + //FSGDebugGizmo::Draw(World, Location, Rotation, DebugGizmoSettings); } void USGWristTrackerComponent::FImplDeleter::operator()(const FImpl* P) const