From 6c4c51d85fa472d039b4edbaac15d05dbb5c140c Mon Sep 17 00:00:00 2001 From: Mamadou Babaei Date: Fri, 17 Jan 2025 13:40:00 +0100 Subject: [PATCH] make the handbook scp operations safer by utilizing quotes --- Handbook/GNUmakefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Handbook/GNUmakefile b/Handbook/GNUmakefile index 5a75de6d..59cfde63 100644 --- a/Handbook/GNUmakefile +++ b/Handbook/GNUmakefile @@ -575,14 +575,14 @@ endif # ($(SG_BUILD_PLATFORM),$(SG_BUILD_PLATFORM_LINUX)) @echo "Uploading '$(SG_HANDBOOK_DEPLOY_GENERATED_PDF_FILE)' to '$(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR)/$(SG_HANDBOOK_REVISION)'..." @scp \ -P $(SG_HANDBOOK_SSH_PORT) \ - $(SG_HANDBOOK_DEPLOY_GENERATED_PDF_FILE) \ + "$(SG_HANDBOOK_DEPLOY_GENERATED_PDF_FILE)" \ $(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR)/$(SG_HANDBOOK_REVISION) @echo "Copying '$(SG_DOCUMENTATION_EPUB_FILE)' to '$(SG_HANDBOOK_DEPLOY_GENERATED_EPUB_FILE)'..." @cp -v "$(SG_DOCUMENTATION_EPUB_FILE)" "$(SG_HANDBOOK_DEPLOY_GENERATED_EPUB_FILE)" @echo "Uploading '$(SG_HANDBOOK_DEPLOY_GENERATED_EPUB_FILE)' to '$(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR)/$(SG_HANDBOOK_REVISION)'..." @scp \ -P $(SG_HANDBOOK_SSH_PORT) \ - $(SG_HANDBOOK_DEPLOY_GENERATED_EPUB_FILE) \ + "$(SG_HANDBOOK_DEPLOY_GENERATED_EPUB_FILE)" \ $(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR)/$(SG_HANDBOOK_REVISION) @echo "Retrieving the list of deployed handbook revisions from '$(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_PORT)/$(SG_HANDBOOK_SSH_REMOTE_DIR)'..." @ssh \ @@ -682,10 +682,10 @@ endif # ($(SG_BUILD_PLATFORM),$(SG_BUILD_PLATFORM_LINUX)) @echo "Uploading '$(SG_HANDBOOK_FAVICON_FILE)' to '$(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR)'" @scp \ -P $(SG_HANDBOOK_SSH_PORT) \ - $(SG_HANDBOOK_FAVICON_FILE) \ + "$(SG_HANDBOOK_FAVICON_FILE)" \ $(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR) @echo "Uploading '$(SG_HANDBOOK_DEPLOY_GENERATED_HOME_INDEX_FILE)' to '$(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR)'" @scp \ -P $(SG_HANDBOOK_SSH_PORT) \ - $(SG_HANDBOOK_DEPLOY_GENERATED_HOME_INDEX_FILE) \ + "$(SG_HANDBOOK_DEPLOY_GENERATED_HOME_INDEX_FILE)" \ $(SG_HANDBOOK_SSH_USER)@$(SG_HANDBOOK_SSH_HOST):$(SG_HANDBOOK_SSH_REMOTE_DIR) \ No newline at end of file