From 90805084ec70a9ed30ad151540fb91f1aa12dfa6 Mon Sep 17 00:00:00 2001 From: Mamadou Babaei Date: Mon, 7 Jul 2025 18:23:37 +0200 Subject: [PATCH] remove remnants of long removed unreal 5.2 from third-party modules *.Build.cs files --- Handbook/src/appendix/changelog.md | 14 ++++++++++++++ .../Private/SGTracking/SGXRTracker.cpp | 11 ----------- .../Public/SGTracking/SGXRTracker.h | 8 -------- .../SGConnectThirdPartyLibs.Build.cs | 4 ---- .../SGCoreThirdPartyLibs.Build.cs | 4 ---- .../SGSerialThirdPartyLibs.Build.cs | 4 ---- 6 files changed, 14 insertions(+), 31 deletions(-) diff --git a/Handbook/src/appendix/changelog.md b/Handbook/src/appendix/changelog.md index a7521239..2d00a797 100644 --- a/Handbook/src/appendix/changelog.md +++ b/Handbook/src/appendix/changelog.md @@ -5,6 +5,20 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [Unreleased] + +### Fixed + +- Fix a typo in the function name `SGDeviceList::SenseCommRunning()`. This fix breaks ABI and API compatibility with previous versions of the plugin and affects both C++ and Blueprint code. + +### Changed + +- `SGDeviceList::SenseCommRunning()` has been renamed to `SGDeviceList::SenseComRunning()` due to a typo. This change breaks ABI and API compatibility with previous versions of the plugin and affects both C++ and Blueprint code. + +### Removed + +- Cleaned up remnants of the long-removed Unreal Engine `5.2` from third-party module `*.Build.cs` files. + ## [2.6.3] - 2025-06-27 This patch release contains no changes to the plugin code. It includes only documentation updates and improvements. diff --git a/Source/SenseGloveTracking/Private/SGTracking/SGXRTracker.cpp b/Source/SenseGloveTracking/Private/SGTracking/SGXRTracker.cpp index 65cbca24..00c7246c 100644 --- a/Source/SenseGloveTracking/Private/SGTracking/SGXRTracker.cpp +++ b/Source/SenseGloveTracking/Private/SGTracking/SGXRTracker.cpp @@ -1726,15 +1726,9 @@ void FSGXRTracker::UpdateDeviceLocations( } } -#if ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 bool FSGXRTracker::GetControllerOrientationAndPosition(const int32 ControllerIndex, const FName MotionSource, FRotator& OutOrientation, FVector& OutPosition, const float WorldToMetersScale) const -#else /* ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 */ -bool FSGXRTracker::GetControllerOrientationAndPosition(const int32 ControllerIndex, const EControllerHand DeviceHand, - FRotator& OutOrientation, FVector& OutPosition, - const float WorldToMetersScale) const -#endif /* ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 */ { if (!IsHandTrackingStateValid()) { @@ -1769,12 +1763,7 @@ bool FSGXRTracker::GetControllerOrientationAndPosition(const int32 ControllerInd return bGotTransform; } -#if ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 ETrackingStatus FSGXRTracker::GetControllerTrackingStatus(const int32 ControllerIndex, const FName MotionSource) const -#else /* ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 */ -ETrackingStatus FSGXRTracker::GetControllerTrackingStatus(const int32 ControllerIndex, - const EControllerHand DeviceHand) const -#endif /* ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 */ { if (!IsHandTrackingStateValid()) { diff --git a/Source/SenseGloveTracking/Public/SGTracking/SGXRTracker.h b/Source/SenseGloveTracking/Public/SGTracking/SGXRTracker.h index 61a77a30..a32b205b 100644 --- a/Source/SenseGloveTracking/Public/SGTracking/SGXRTracker.h +++ b/Source/SenseGloveTracking/Public/SGTracking/SGXRTracker.h @@ -136,19 +136,11 @@ public: public: // The IMotionController interface. -#if ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 virtual bool GetControllerOrientationAndPosition(const int32 ControllerIndex, const FName MotionSource, FRotator& OutOrientation, FVector& OutPosition, float WorldToMetersScale) const override; virtual ETrackingStatus GetControllerTrackingStatus(const int32 ControllerIndex, const FName MotionSource) const override; -#else /* ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 */ - virtual bool GetControllerOrientationAndPosition(const int32 ControllerIndex, const EControllerHand DeviceHand, - FRotator& OutOrientation, FVector& OutPosition, - float WorldToMetersScale) const override; - virtual ETrackingStatus GetControllerTrackingStatus(const int32 ControllerIndex, - const EControllerHand DeviceHand) const override; -#endif /* ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 3 */ virtual FName GetMotionControllerDeviceTypeName() const override; virtual void EnumerateSources(TArray& SourcesOut) const override; diff --git a/Source/ThirdParty/SGConnectThirdPartyLibs/SGConnectThirdPartyLibs.Build.cs b/Source/ThirdParty/SGConnectThirdPartyLibs/SGConnectThirdPartyLibs.Build.cs index 73bfa2d4..5786864e 100644 --- a/Source/ThirdParty/SGConnectThirdPartyLibs/SGConnectThirdPartyLibs.Build.cs +++ b/Source/ThirdParty/SGConnectThirdPartyLibs/SGConnectThirdPartyLibs.Build.cs @@ -79,8 +79,6 @@ public class SGConnectThirdPartyLibs : ModuleRules LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v23")); #elif UE_5_3_OR_LATER LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v22")); -#elif UE_5_2_OR_LATER - LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v21")); #else Debug.Assert(false, "Unsupported engine version or compiler!"); #endif @@ -98,8 +96,6 @@ public class SGConnectThirdPartyLibs : ModuleRules LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v23")); #elif UE_5_3_OR_LATER LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v22")); -#elif UE_5_2_OR_LATER - LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v21")); #else Debug.Assert(false, "Unsupported engine version or compiler!"); #endif diff --git a/Source/ThirdParty/SGCoreThirdPartyLibs/SGCoreThirdPartyLibs.Build.cs b/Source/ThirdParty/SGCoreThirdPartyLibs/SGCoreThirdPartyLibs.Build.cs index a96ece83..e5e0f03c 100644 --- a/Source/ThirdParty/SGCoreThirdPartyLibs/SGCoreThirdPartyLibs.Build.cs +++ b/Source/ThirdParty/SGCoreThirdPartyLibs/SGCoreThirdPartyLibs.Build.cs @@ -79,8 +79,6 @@ public class SGCoreThirdPartyLibs : ModuleRules LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v23")); #elif UE_5_3_OR_LATER LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v22")); -#elif UE_5_2_OR_LATER - LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v21")); #else Debug.Assert(false, "Unsupported engine version or compiler!"); #endif @@ -98,8 +96,6 @@ public class SGCoreThirdPartyLibs : ModuleRules LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v23")); #elif UE_5_3_OR_LATER LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v22")); -#elif UE_5_2_OR_LATER - LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v21")); #else Debug.Assert(false, "Unsupported engine version or compiler!"); #endif diff --git a/Source/ThirdParty/SGSerialThirdPartyLibs/SGSerialThirdPartyLibs.Build.cs b/Source/ThirdParty/SGSerialThirdPartyLibs/SGSerialThirdPartyLibs.Build.cs index 2444504f..1a1da11c 100644 --- a/Source/ThirdParty/SGSerialThirdPartyLibs/SGSerialThirdPartyLibs.Build.cs +++ b/Source/ThirdParty/SGSerialThirdPartyLibs/SGSerialThirdPartyLibs.Build.cs @@ -79,8 +79,6 @@ public class SGSerialThirdPartyLibs : ModuleRules LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v23")); #elif UE_5_3_OR_LATER LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v22")); -#elif UE_5_2_OR_LATER - LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v21")); #else Debug.Assert(false, "Unsupported engine version or compiler!"); #endif @@ -98,8 +96,6 @@ public class SGSerialThirdPartyLibs : ModuleRules LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v23")); #elif UE_5_3_OR_LATER LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v22")); -#elif UE_5_2_OR_LATER - LibraryPath = Path.GetFullPath(Path.Combine(LibraryPath, "v21")); #else Debug.Assert(false, "Unsupported engine version or compiler!"); #endif