From a619203446ccc1927f6da975b12f2a2a773ec732 Mon Sep 17 00:00:00 2001 From: Mamadou Babaei Date: Tue, 4 Jun 2024 12:18:40 +0200 Subject: [PATCH] removed the allbreaker virtual hand model as it's no longer compatible with the openxr integration --- CHANGELOG.md | 1 + .../PHYS_Allbreaker_VirtualHand_Left.uasset | 3 --- .../PHYS_Allbreaker_VirtualHand_Right.uasset | 3 --- .../SKEL_Allbreaker_VirtualHand_Left.uasset | 3 --- .../SKEL_Allbreaker_VirtualHand_Right.uasset | 3 --- .../SK_Allbreaker_VirtualHand_Left.uasset | 3 --- .../SK_Allbreaker_VirtualHand_Right.uasset | 3 --- LICENSE-THIRD-PARTY.md | 15 +-------------- .../Components/SGVirtualHandComponent.cpp | 16 ++++++++-------- 9 files changed, 10 insertions(+), 40 deletions(-) delete mode 100644 Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Left.uasset delete mode 100644 Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Right.uasset delete mode 100644 Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Left.uasset delete mode 100644 Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Right.uasset delete mode 100644 Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Left.uasset delete mode 100644 Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Right.uasset diff --git a/CHANGELOG.md b/CHANGELOG.md index a29c9e73..9d740757 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,7 @@ This is a minor release focusing mainly on bringing OpenXR-compatible hand track ### Removed - Dropped support for Unreal Engine 5.1 and Epic Native Toolchain v20 (used to build UE 5.0 and 5.1 Linux dependencies). +- Removed the Allbreaker virtual hand model as it's no longer compatible with the SenseGlove plugin. - Removed ASGVirtualHandActor as it was experimental and we no longer maintain it and haven't been doing so for a long time. - Removed FSGVirtualHandAnimInstanceProxy::GetBonesRotations(). - Removed USGVirtualHandComponent::GetHandPose() and it's no longer possible to get the hand pose data from USGVirtualHandComponent as GetHandPose() has been removed. If you need it, you could always use the SenseGlove low-level API to retrieve it from the glove. diff --git a/Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Left.uasset b/Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Left.uasset deleted file mode 100644 index 471b9f79..00000000 --- a/Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Left.uasset +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:fba997aba50224224668b4aa3fb2b432c22511c47ba0f009c43b25cd8853436e -size 7840 diff --git a/Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Right.uasset b/Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Right.uasset deleted file mode 100644 index c3e272b0..00000000 --- a/Content/Meshes/Allbreaker/PHYS_Allbreaker_VirtualHand_Right.uasset +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:851ce24d92753c0af7cb83a0802bb1bf69e5b9ea70a6a9e076a3c6c490342497 -size 7963 diff --git a/Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Left.uasset b/Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Left.uasset deleted file mode 100644 index 661016f7..00000000 --- a/Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Left.uasset +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:49146ba0517ccdcc27d1586e4b9816690d502b697414e962d79ff69ceb18093b -size 20060 diff --git a/Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Right.uasset b/Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Right.uasset deleted file mode 100644 index c3ab62d7..00000000 --- a/Content/Meshes/Allbreaker/SKEL_Allbreaker_VirtualHand_Right.uasset +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:1677925b69e2bd456a11c3d3e0b3d19958a2963250e0e27d9b8b8765af831724 -size 19928 diff --git a/Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Left.uasset b/Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Left.uasset deleted file mode 100644 index 4d304fbb..00000000 --- a/Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Left.uasset +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:8b61e79f4ffff4776d9a0b5ffca5c0866e5d21c8589ade5665b3334a4f64c603 -size 560503 diff --git a/Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Right.uasset b/Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Right.uasset deleted file mode 100644 index 6125c3c4..00000000 --- a/Content/Meshes/Allbreaker/SK_Allbreaker_VirtualHand_Right.uasset +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:28e67725226a3e1fca5ec9c22ed55b4110540fc20f2801e6a0775b0d7f9d4847 -size 561427 diff --git a/LICENSE-THIRD-PARTY.md b/LICENSE-THIRD-PARTY.md index b21e0f4a..9f6f6628 100644 --- a/LICENSE-THIRD-PARTY.md +++ b/LICENSE-THIRD-PARTY.md @@ -84,17 +84,4 @@ FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. -``` - -## Allbreaker Virtual Hand Models - -``` -The virtual hand model mesh included in this plugin, situated within the -‘Contents/Meshes/Allbreaker’ folder, is graciously supplied by Allbreaker LLC -Colombia. This provision is made pursuant to an agreement between SenseGlove -B.V. and Allbreaker LLC. Users of this plugin are bound by the terms outlined in -the license agreement and are advised to review the terms and conditions -specified therein. -Please visit https://www.allbreaker.co/ to obtain information about the work of -Allbreaker. -``` +``` \ No newline at end of file diff --git a/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp b/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp index 18fac3a9..b82bea98 100644 --- a/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp +++ b/Source/SenseGlove/Private/SenseGlove/Components/SGVirtualHandComponent.cpp @@ -61,29 +61,29 @@ struct USGVirtualHandComponent::FImpl FORCEINLINE static const FString& GetDefaultLeftHandMeshPath() { - static const FString Path{TEXT("SkeletalMesh'/SenseGlove/Meshes/Allbreaker/" - "SK_Allbreaker_VirtualHand_Left.SK_Allbreaker_VirtualHand_Left'")}; + static const FString Path{TEXT("SkeletalMesh'/SenseGlove/Meshes/" + "SK_SenseGlove_VirtualHand_Left.SK_SenseGlove_VirtualHand_Left'")}; return Path; } FORCEINLINE static const FString& GetDefaultLeftHandMeshPathOnly() { - static const FString Path{TEXT("/SenseGlove/Meshes/Allbreaker/" - "SK_Allbreaker_VirtualHand_Left.SK_Allbreaker_VirtualHand_Left")}; + static const FString Path{TEXT("/SenseGlove/Meshes/" + "SK_SenseGlove_VirtualHand_Left.SK_SenseGlove_VirtualHand_Left")}; return Path; } FORCEINLINE static const FString& GetDefaultRightHandMeshPath() { - static const FString Path{TEXT("SkeletalMesh'/SenseGlove/Meshes/Allbreaker/" - "SK_Allbreaker_VirtualHand_Right.SK_Allbreaker_VirtualHand_Right'")}; + static const FString Path{TEXT("SkeletalMesh'/SenseGlove/Meshes/" + "SK_SenseGlove_VirtualHand_Right.SK_SenseGlove_VirtualHand_Right'")}; return Path; } FORCEINLINE static const FString& GetDefaultRightHandMeshPathOnly() { - static const FString Path{TEXT("/SenseGlove/Meshes/Allbreaker/" - "SK_Allbreaker_VirtualHand_Right.SK_Allbreaker_VirtualHand_Right")}; + static const FString Path{TEXT("/SenseGlove/Meshes/" + "SK_SenseGlove_VirtualHand_Right.SK_SenseGlove_VirtualHand_Right")}; return Path; }