diff --git a/Handbook/GNUmakefile b/Handbook/GNUmakefile index eee79878..67d2e70a 100644 --- a/Handbook/GNUmakefile +++ b/Handbook/GNUmakefile @@ -38,6 +38,9 @@ SG_PLUGIN_RESOURCES_DIR := $(SG_PLUGIN_DIR)/Resources SG_PLUGIN_FILE := $(SG_PLUGIN_DIR)/SenseGlove.uplugin SG_DOCUMENTATION_DIR := $(SG_PLUGIN_DIR)/Documentation +SG_BROWSER_BINARY_PATH_LINUX := $(shell which brave-bin 2>/dev/null) +SG_BROWSER_BINARY_PATH_WINDOWS := C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe + ################################################################################ # Platform Detection ################################################################################ @@ -167,6 +170,18 @@ ifeq ($(strip $(SG_HANDBOOK_REVISION)),) SG_HANDBOOK_REVISION := mismatched endif # ($(strip $(SG_HANDBOOK_REVISION)),) +################################################################################ +# mdbook-pdf configuration +################################################################################ + +ifeq ($(SG_BUILD_PLATFORM),$(SG_BUILD_PLATFORM_LINUX)) +SG_MDBOOK_PDF_BROWSER_BINARY_PATH := $(SG_BROWSER_BINARY_PATH_LINUX) +else ifeq ($(SG_BUILD_PLATFORM),$(SG_BUILD_PLATFORM_WINDOWS)) +SG_MDBOOK_PDF_BROWSER_BINARY_PATH := $(SG_BROWSER_BINARY_PATH_WINDOWS) +else # ($(SG_BUILD_PLATFORM),$(SG_BUILD_PLATFORM_LINUX)) +$(error The target operating system is not supported!) +endif # ($(SG_BUILD_PLATFORM),$(SG_BUILD_PLATFORM_LINUX)) + ################################################################################ # Make Targets - All ################################################################################ @@ -294,6 +309,7 @@ serve: SG_PLUGIN_VERSION_PATCH='$(SG_PLUGIN_VERSION_PATCH)' \ SG_BUILD_HOST='$(SG_BUILD_HOST)' \ SG_BUILD_TIME='$(SG_BUILD_TIME)' \ + MDBOOK_output__pdf__browser_binary_path='$(SG_MDBOOK_PDF_BROWSER_BINARY_PATH)' \ mdbook serve \ -n $(SG_MDBOOK_HOST) \ -p $(SG_MDBOOK_PORT) \ diff --git a/Handbook/README.md b/Handbook/README.md index abac5753..20b50352 100644 --- a/Handbook/README.md +++ b/Handbook/README.md @@ -2,6 +2,7 @@ ## Prerequisites +- Brave Browser (for PDF generation; in case you have Brave installed in a non-conventional path, or you'd like to use a different Chromium-based browser you need to adjust the path inside the GNUmakefile) - GNU Make - Git - The Rust Toolchain diff --git a/Handbook/book.toml b/Handbook/book.toml index 023d7834..1cfebbb8 100644 --- a/Handbook/book.toml +++ b/Handbook/book.toml @@ -86,7 +86,6 @@ teaser-word-count = 64 use-boolean-and = true [output.pdf] -browser-binary-path = "/usr/bin/brave-bin" trying-times = 1 timeout = 300 # https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-printToPDF @@ -108,4 +107,4 @@ prefer-css-page-size = true [output.pdf-outline] optional = true -like-wkhtmltopdf = false +like-wkhtmltopdf = false \ No newline at end of file