From e29c037198e119dd8adc7b1b4830ed1988468752 Mon Sep 17 00:00:00 2001
From: Mamadou Babaei <info@babaei.net>
Date: Wed, 14 Feb 2024 14:40:03 +0100
Subject: [PATCH] fix the NovaGlove class instantiation methods to initialize a
 NovaGloveImpl instead of a SenseGloveImpl

---
 CHANGELOG.md                                         |  8 ++++++++
 Source/SenseGloveCore/Private/SGCore/SGNovaGlove.cpp | 10 +++++-----
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2f5d6940..78bab9c3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+This is a bugfix release.
+
+### Fixed
+
+- Fix a few critical bugs inside the NovaGlove class where the higher levels of the API including constructors, Parse, and NewNovaGlove methods mistakenly instantiate a SenseGloveImpl class instead of a NovaGloveImpl class.
+
 ## [1.9.5] - 2024-02-09
 
 This is a bugfix release.
diff --git a/Source/SenseGloveCore/Private/SGCore/SGNovaGlove.cpp b/Source/SenseGloveCore/Private/SGCore/SGNovaGlove.cpp
index 90ffbea8..7f73dbaa 100644
--- a/Source/SenseGloveCore/Private/SGCore/SGNovaGlove.cpp
+++ b/Source/SenseGloveCore/Private/SGCore/SGNovaGlove.cpp
@@ -87,7 +87,7 @@ USGNovaGlove* USGNovaGlove::NewNovaGlove(UObject* Outer, TSharedRef<FSGNovaGlove
 USGNovaGlove* USGNovaGlove::NewNovaGlove(UObject* Outer)
 {
     FSGIC_TSharedPtr_FSGNovaGloveImpl OutSharedPtrContainer;
-    SGCoreImpl_FSGSenseGloveImpl_ctor_MakeShared(&OutSharedPtrContainer);
+    SGCoreImpl_FSGNovaGloveImpl_ctor_MakeShared(&OutSharedPtrContainer);
 
     return NewNovaGlove(Outer, OutSharedPtrContainer.Ptr.ToSharedRef());
 }
@@ -96,7 +96,7 @@ USGNovaGlove* USGNovaGlove::NewNovaGlove(UObject* Outer, const USGNovaGloveInfo&
 {
     FSGIC_TSharedPtr_FSGNovaGloveImpl OutSharedPtrContainer;
     FSGIC_FSGNovaGloveInfoImpl DeviceInfoContainer{DeviceInfo.ToNovaGloveInfoImpl()};
-    SGCoreImpl_FSGSenseGloveImpl_ctor_Model_MakeShared(&OutSharedPtrContainer, &DeviceInfoContainer);
+    SGCoreImpl_FSGNovaGloveImpl_ctor_DeviceInfo_MakeShared(&OutSharedPtrContainer, &DeviceInfoContainer);
 
     return NewNovaGlove(Outer, OutSharedPtrContainer.Ptr.ToSharedRef());
 }
@@ -132,7 +132,7 @@ USGDevice* USGNovaGlove::Parse(UObject* Outer, const FString& ConstantsString)
 {
     FSGIC_FSGNovaGloveImpl OutNovaGloveImplContainer;
     FSGIC_FString ConstantsStringContainer{ConstantsString};
-    SGCoreImpl_FSGSenseGloveImpl_Parse(&OutNovaGloveImplContainer, &ConstantsStringContainer);
+    SGCoreImpl_FSGNovaGloveImpl_Parse(&OutNovaGloveImplContainer, &ConstantsStringContainer);
 
     return NewNovaGlove(Outer, MoveTemp(OutNovaGloveImplContainer.NovaGloveImpl));
 }
@@ -303,7 +303,7 @@ USGNovaGlove::USGNovaGlove()
     : USGHapticGlove()
 {
     FSGIC_TSharedPtr_FSGNovaGloveImpl OutSharedPtrContainer;
-    SGCoreImpl_FSGSenseGloveImpl_ctor_MakeShared(&OutSharedPtrContainer);
+    SGCoreImpl_FSGNovaGloveImpl_ctor_MakeShared(&OutSharedPtrContainer);
 
     SetSGDeviceImpl(OutSharedPtrContainer.Ptr.ToSharedRef());
 }
@@ -313,7 +313,7 @@ USGNovaGlove::USGNovaGlove(const USGNovaGloveInfo& DeviceInfo)
 {
     FSGIC_TSharedPtr_FSGNovaGloveImpl OutSharedPtrContainer;
     FSGIC_FSGNovaGloveInfoImpl DeviceInfoContainer{DeviceInfo.ToNovaGloveInfoImpl()};
-    SGCoreImpl_FSGSenseGloveImpl_ctor_Model_MakeShared(&OutSharedPtrContainer, &DeviceInfoContainer);
+    SGCoreImpl_FSGNovaGloveImpl_ctor_DeviceInfo_MakeShared(&OutSharedPtrContainer, &DeviceInfoContainer);
 
     SetSGDeviceImpl(OutSharedPtrContainer.Ptr.ToSharedRef());
 }