UnrealEngine/Plugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add some performance optimizations by utilizing MoveTemp in return statements

Browse Source
This commit is contained in:
Mamadou Babaei
2024-03-12 10:43:22 +01:00
parent 545f65485f
commit e4291bb9e8
5 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/SenseGloveCoreImpl/Private/SGCoreImpl/SGBasicHandModelImpl.cpp
+10 -10
View File
@@ -302,10 +302,10 @@ void FSGBasicHandModelImpl::SetJointRotation(const FQuat& NewRotation, const ESG
TArray<float> FSGBasicHandModelImpl::GetTotalLengths() const
{
const TArray<float> TotalLengths{
TArray<float> TotalLengths{
FSGArrayUtils::FromMillimeters(Pimpl->BasicHandModel.GetTotalLengths())
};
return TotalLengths;
return MoveTemp(TotalLengths);
}
float FSGBasicHandModelImpl::GetTotalLength(const ESGFinger Finger) const
@@ -316,11 +316,11 @@ float FSGBasicHandModelImpl::GetTotalLength(const ESGFinger Finger) const
TArray<FVector> FSGBasicHandModelImpl::Get3DLengths(const ESGFinger Finger) const
{
const TArray<FVector> Lengths{
TArray<FVector> Lengths{
FSGArrayUtils::FromMillimeters<FSGVect3DImpl::FVect3DType, FSGVect3DImpl>(
Pimpl->BasicHandModel.Get3DLengths(FSGCoreEnumCast::ToEFinger(Finger)))
};
return Lengths;
return MoveTemp(Lengths);
}
bool FSGBasicHandModelImpl::Equals(const FSGBasicHandModelImpl& BasicHandModelImpl) const
@@ -330,20 +330,20 @@ bool FSGBasicHandModelImpl::Equals(const FSGBasicHandModelImpl& BasicHandModelIm
FString FSGBasicHandModelImpl::ToString() const
{
const FString String(UTF8_TO_TCHAR(Pimpl->BasicHandModel.ToString().c_str()));
return String;
FString String(UTF8_TO_TCHAR(Pimpl->BasicHandModel.ToString().c_str()));
return MoveTemp(String);
}
FString FSGBasicHandModelImpl::ToString(const bool bLengthsOnly) const
{
const FString String(UTF8_TO_TCHAR(Pimpl->BasicHandModel.ToString(bLengthsOnly).c_str()));
return String;
FString String(UTF8_TO_TCHAR(Pimpl->BasicHandModel.ToString(bLengthsOnly).c_str()));
return MoveTemp(String);
}
FString FSGBasicHandModelImpl::Serialize() const
{
const FString Serialized(UTF8_TO_TCHAR(Pimpl->BasicHandModel.Serialize().c_str()));
return Serialized;
FString Serialized(UTF8_TO_TCHAR(Pimpl->BasicHandModel.Serialize().c_str()));
return MoveTemp(Serialized);
}
FSGBasicHandModelImpl::FImpl::FImpl(FSGBasicHandModelImpl* InOwner)
Source/SenseGloveCoreImpl/Private/SGCoreImpl/SGDeviceImpl.cpp
+8 -8
View File
@@ -98,8 +98,8 @@ bool FSGDeviceImpl::FirmwareOlderThan(const int32 MyFirmwareMain, const int32 My
FString FSGDeviceImpl::ToString(const ESGDeviceType DeviceType)
{
const FString String{UTF8_TO_TCHAR(FSGDeviceType::ToString(FSGCoreEnumCast::ToEDeviceType(DeviceType)).c_str())};
return String;
FString String{UTF8_TO_TCHAR(FSGDeviceType::ToString(FSGCoreEnumCast::ToEDeviceType(DeviceType)).c_str())};
return MoveTemp(String);
}
FSGDeviceImpl::FSGDeviceImpl()
@@ -298,8 +298,8 @@ int32 FSGDeviceImpl::GetSubFirmwareVersion() const
FString FSGDeviceImpl::GetFirmwareString() const
{
const FString String{UTF8_TO_TCHAR(ToSGDevicePtrChecked()->GetFirmwareString().c_str())};
return String;
FString String{UTF8_TO_TCHAR(ToSGDevicePtrChecked()->GetFirmwareString().c_str())};
return MoveTemp(String);
}
bool FSGDeviceImpl::FirmwareNewerThan(const int32 FirmwareMain, const int32 FirmwareSub, const bool bInclusive) const
@@ -314,8 +314,8 @@ bool FSGDeviceImpl::FirmwareOlderThan(const int32 FirmwareMain, const int32 Firm
FString FSGDeviceImpl::GetAddress() const
{
const FString String(UTF8_TO_TCHAR(ToSGDevicePtrChecked()->GetAddress().c_str()));
return String;
FString String(UTF8_TO_TCHAR(ToSGDevicePtrChecked()->GetAddress().c_str()));
return MoveTemp(String);
}
bool FSGDeviceImpl::IsConnected() const
@@ -385,8 +385,8 @@ int32 FSGDeviceImpl::GetHapticChannelCount(const ESGHapticChannelType ChannelTyp
FString FSGDeviceImpl::ToString() const
{
const FString String(UTF8_TO_TCHAR(ToSGDevicePtrChecked()->ToString().c_str()));
return String;
FString String(UTF8_TO_TCHAR(ToSGDevicePtrChecked()->ToString().c_str()));
return MoveTemp(String);
}
FSGDeviceImpl::FImpl::FImpl(FSGDeviceImpl* InOwner)
Source/SenseGloveCoreImpl/Private/SGCoreImpl/SGHandInterpolatorImpl.cpp
+2 -2
View File
@@ -170,8 +170,8 @@ bool FSGHandInterpolatorImpl::Equals(const FSGHandInterpolatorImpl& HandInterpol
FString FSGHandInterpolatorImpl::Serialize() const
{
const FString Serialized(UTF8_TO_TCHAR(Pimpl->HandInterpolator.Serialize().c_str()));
return Serialized;
FString Serialized(UTF8_TO_TCHAR(Pimpl->HandInterpolator.Serialize().c_str()));
return MoveTemp(Serialized);
}
FSGHandInterpolatorImpl::FImpl::FImpl(FSGHandInterpolatorImpl* InOwner)
Source/SenseGloveCoreImpl/Private/SGCoreImpl/SGInterpolationSetImpl.cpp
+6 -6
View File
@@ -200,20 +200,20 @@ bool FSGInterpolationSetImpl::Equals(const FSGInterpolationSetImpl& Interpolatio
FString FSGInterpolationSetImpl::ToString() const
{
const FString String(UTF8_TO_TCHAR(Pimpl->InterpolationSet.ToString().c_str()));
return String;
FString String(UTF8_TO_TCHAR(Pimpl->InterpolationSet.ToString().c_str()));
return MoveTemp(String);
}
FString FSGInterpolationSetImpl::ToString(const bool bLimits) const
{
const FString String(UTF8_TO_TCHAR(Pimpl->InterpolationSet.ToString(bLimits).c_str()));
return String;
FString String(UTF8_TO_TCHAR(Pimpl->InterpolationSet.ToString(bLimits).c_str()));
return MoveTemp(String);
}
FString FSGInterpolationSetImpl::Serialize() const
{
const FString Serialized(UTF8_TO_TCHAR(Pimpl->InterpolationSet.Serialize().c_str()));
return Serialized;
FString Serialized(UTF8_TO_TCHAR(Pimpl->InterpolationSet.Serialize().c_str()));
return MoveTemp(Serialized);
}
FSGInterpolationSetImpl::FImpl::FImpl(FSGInterpolationSetImpl* InOwner)
Source/SenseGloveCoreImpl/Private/SGCoreImpl/SGSenseGloveVarsImpl.cpp
+12 -12
View File
@@ -51,47 +51,47 @@ FString FSGSenseGloveVarsImpl::GetStandardConstantsString(const FString& Hardwar
const bool bRightHanded)
{
std::string HardwareVersionString(TCHAR_TO_UTF8(*HardwareVersion));
const FString String(UTF8_TO_TCHAR(FSenseGloveVarsType::GetStandardConstantsString(MoveTemp(HardwareVersionString),
FString String(UTF8_TO_TCHAR(FSenseGloveVarsType::GetStandardConstantsString(MoveTemp(HardwareVersionString),
FirmwareVersion, bRightHanded).c_str()));
return String;
return MoveTemp(String);
}
FString FSGSenseGloveVarsImpl::GetSensorString(const FString& HardwareVersion, const float FirmwareVersion)
{
std::string HardwareVersionString(TCHAR_TO_UTF8(*HardwareVersion));
const FString String(UTF8_TO_TCHAR(FSenseGloveVarsType::GetSensorString(MoveTemp(HardwareVersionString),
FString String(UTF8_TO_TCHAR(FSenseGloveVarsType::GetSensorString(MoveTemp(HardwareVersionString),
FirmwareVersion).c_str()));
return String;
return MoveTemp(String);
}
TArray<FVector> FSGSenseGloveVarsImpl::GetStartPositions(const FString& HardwareVersion, const bool bRightHanded)
{
std::string HardwareVersionString(TCHAR_TO_UTF8(*HardwareVersion));
const TArray<FVector> StartPositions{
TArray<FVector> StartPositions{
FSGArrayUtils::FromMillimeters<FSGVect3DImpl::FVect3DType, FSGVect3DImpl>(
FSenseGloveVarsType::GetStartPositions(MoveTemp(HardwareVersionString), bRightHanded))
};
return StartPositions;
return MoveTemp(StartPositions);
}
TArray<FQuat> FSGSenseGloveVarsImpl::GetStartRotations(const FString& HardwareVersion, const bool bRightHanded)
{
std::string HardwareVersionString(TCHAR_TO_UTF8(*HardwareVersion));
const TArray<FQuat> StartRotations{
TArray<FQuat> StartRotations{
FSGArrayUtils::FromStdVector<FSGQuatImpl::FQuatType, FQuat, FSGQuatImpl, &FSGQuatImpl::ToFQuat>(
FSenseGloveVarsType::GetStartRotations(MoveTemp(HardwareVersionString), bRightHanded))
};
return StartRotations;
return MoveTemp(StartRotations);
}
TArray<TArray<FVector>> FSGSenseGloveVarsImpl::GetGloveLengths(const FString& HardwareVersion)
{
std::string HardwareVersionString(TCHAR_TO_UTF8(*HardwareVersion));
const TArray<TArray<FVector>> GloveLengths{
TArray<TArray<FVector>> GloveLengths{
FSGArrayUtils::FromMillimeters<FSGVect3DImpl::FVect3DType, FSGVect3DImpl>(
FSenseGloveVarsType::GetGloveLengths(MoveTemp(HardwareVersionString)))
};
return GloveLengths;
return MoveTemp(GloveLengths);
}
int32 FSGSenseGloveVarsImpl::GetSensors(const FString& HardwareVersion)
@@ -112,10 +112,10 @@ TArray<bool> FSGSenseGloveVarsImpl::GetFunctions(const FString& HardwareVersion,
const int32 SubFirmwareVersion)
{
std::string HardwareVersionString(TCHAR_TO_UTF8(*HardwareVersion));
const TArray<bool> Functions{FSGArrayUtils::FromStdVector(FSenseGloveVarsType::GetFunctions(
TArray<bool> Functions{FSGArrayUtils::FromStdVector(FSenseGloveVarsType::GetFunctions(
MoveTemp(HardwareVersionString), FirmwareVersion, SubFirmwareVersion))
};
return Functions;
return MoveTemp(Functions);
}
FSGSenseGloveInfoImpl FSGSenseGloveVarsImpl::GenerateGloveModel(const FString& HardwareVersion,