bump the plugin version to v1.4.3

update the changelog
fix a critical Android crash that happens where the default development hand meshes are not found
2023-06-01 23:30:53 +02:00 · 2023-06-01 23:30:53 +02:00 · 2023-06-01 23:30:52 +02:00 · 2023-06-01 23:30:52 +02:00 · 2023-06-01 23:30:51 +02:00 · 2023-06-01 21:46:06 +02:00
4 changed files with 73 additions and 31 deletions
@@ -5,7 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

-## [v1.4.2] - 2023-06-01
+## [1.4.3] - 2023-06-01
+
+This is a hotfix release addressing a critical Android crash.
+
+### Fixed
+
+- Fix a critical Android crash that happens where the default development hand meshes are not found, which means almost always since we don't ship any default virtual hand mesh at the moment.
+- Minor changelog release formatting fix in order to stay consistent.
+
+## [1.4.2] - 2023-06-01

 This is a hotfix release addressing a few critical issues.

@@ -15,7 +24,7 @@ This is a hotfix release addressing a few critical issues.
 - Reintroduced the Virtual Hand and the Wrist Tracker debug gizmos which have temporarily been disabled due to a bug in the settings system.
 - Some minor changelog fixes.

-## [v1.4.1] - 2023-05-29
+## [1.4.1] - 2023-05-29

 This is a bugfix release with a focus on Android build issues.

@@ -28,7 +37,7 @@ This is a bugfix release with a focus on Android build issues.

 - Remove dead Gradle code from the Android module.

-## [v1.4.0] - 2023-05-19
+## [1.4.0] - 2023-05-19

 This release breaks ABI/API compatibility with the previous versions.

@@ -57,14 +66,14 @@ This release breaks ABI/API compatibility with the previous versions.

 - This is the last release to support Unreal Engine 4.27 and please keep in mind that the current release is not obtainable through the Unreal Engine Marketplace. The latest published version on the Marketplace for 4.27 is v1.3.1. Per Epic's Marketplace policy regarding Code Plugins, we are only able to distribute or update the SenseGlove plugin for the last 3 stable versions of Unreal Engine. As a result, we won't be able to publish updates or bug fixes for the older versions of the Engine except on rare occasions and only through our official repository on Microsoft Azure DevOps.

-## [v1.3.1] - 2023-04-28
+## [1.3.1] - 2023-04-28

 ### Fixed

 - Fix RunUAT build issues caused by missing headers.
 - Minor documentation fixes.

-## [v1.3.0] - 2023-04-28
+## [1.3.0] - 2023-04-28

 This release breaks ABI/API compatibility with the previous versions in addition to breaking coordinates systems conversions between Unreal Engine and the SenseGlove libraries.

@@ -85,13 +94,13 @@ This release breaks ABI/API compatibility with the previous versions in addition
 - Breaking changes in the SenseGlove/Unreal coordinates systems conversions due to underlying changes in the SenseGlove Core Libraries.
 - SenseGlove libraries have been updated to v2.6.0-aac3d56.

-## [v1.2.1] - 2023-03-30
+## [1.2.1] - 2023-03-30

 ### Fixed

 - Fix RunUAT build issues with Android.

-## [v1.2.0] - 2023-03-28
+## [1.2.0] - 2023-03-28

 This release breaks ABI/API compatibility with the previous versions.

@@ -13,10 +13,10 @@ This repository relies on Git LFS for storing binary blobs (e.g. third-party lib
 | **4.24** |         ⚠️ v1.0.x        |         ⚠️ v1.0.x        |            ❌            |               ⚠️ v1.0.x              |                   ❌                  |         ❌         |              ❌             |         ⚠️ v1.0.4         |
 | **4.25** |         ⚠️ v1.0.x        |         ⚠️ v1.0.x        |            ❌            |               ⚠️ v1.0.x              |                   ❌                  |         ❌         |              ❌             |         ⚠️ v1.0.4         |
 | **4.26** |         ⚠️ v1.0.x        |         ⚠️ v1.0.x        |            ❌            |               ⚠️ v1.0.x              |                   ❌                  |         ❌         |              ❌             |         ⚠️ v1.0.4         |
-| **4.27** |         ✅ v1.4.x        |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r21e)  |          ⚠️ v1.3.1          |         ✅ v1.4.2         |
-| **5.0**  |            ❌            |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r21e)  |          ✅ v1.4.2          |         ✅ v1.4.2         |
-| **5.1**  |            ❌            |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r25b)  |          ✅ v1.4.2          |         ✅ v1.4.2         |
-| **5.2**  |            ❌            |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r25b)  |          ✅ v1.4.2          |         ✅ v1.4.2         |
+| **4.27** |         ✅ v1.4.x        |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r21e)  |          ⚠️ v1.3.1          |         ✅ v1.4.3         |
+| **5.0**  |            ❌            |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r21e)  |          ✅ v1.4.3          |         ✅ v1.4.3         |
+| **5.1**  |            ❌            |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r25b)  |          ✅ v1.4.3          |         ✅ v1.4.3         |
+| **5.2**  |            ❌            |         ✅ v1.4.x        |         ✅ v1.4.x        |               ✅ v1.4.x              |               ✅ v1.4.x               |  ✅ v1.4.x (r25b)  |          ✅ v1.4.3          |         ✅ v1.4.3         |

 * <code>✅</code> Supported
 * <code>⚠️</code> Not supported by the latest release and might be lacking features
@@ -1,7 +1,7 @@
 {
 	"FileVersion": 3,
 	"Version": 1,
-	"VersionName": "1.4.2",
+	"VersionName": "1.4.3",
 	"FriendlyName": "SenseGlove",
 	"Description": "Integrating the SenseGlove haptic controller into Unreal Engine",
 	"Category": "Virtual Reality",
@@ -10,6 +10,7 @@
 	"DocsURL": "https://senseglove.gitlab.io/unreal-blueprint-docs/",
 	"MarketplaceURL": "com.epicgames.launcher://ue/marketplace/product/5e1d408f517b4966a269ec1035de0b9e",
 	"SupportURL": "https://www.senseglove.com/support/",
+	"EngineVersion": "4.27.0",
 	"CanContainContent": true,
 	"IsBetaVersion": false,
 	"IsExperimentalVersion": false,
@@ -27,7 +28,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -38,7 +39,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -49,7 +50,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -60,7 +61,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -71,7 +72,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -82,7 +83,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -93,7 +94,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -104,7 +105,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -115,7 +116,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -126,7 +127,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -136,7 +137,7 @@
 			"LoadingPhase": "PostEngineInit",
 			"WhitelistPlatforms": [
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -147,7 +148,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -158,7 +159,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -169,7 +170,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -180,7 +181,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -191,7 +192,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -202,7 +203,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		},
@@ -213,7 +214,7 @@
 			"WhitelistPlatforms": [
 				"Android",
 				"Linux",
-				"LinuxArm64",
+				"LinuxAArch64",
 				"Win64"
 			]
 		}
@@ -114,6 +114,7 @@ struct USGVirtualHandComponent::FImpl
    bool IsEditor() const;

    FString GetDefaultMeshPath() const;
+    bool IsUsingDefaultMesh() const;
    bool IsUsingUserMesh() const;
    USkeletalMesh* LoadDefaultMesh() const;
    void SetDefaultMesh() const;
@@ -514,6 +515,30 @@ FString USGVirtualHandComponent::FImpl::GetDefaultMeshPath() const
    return MoveTemp(SkeletalMeshPath);
 }

+bool USGVirtualHandComponent::FImpl::IsUsingDefaultMesh() const
+{
+    const USkeletalMesh* CurrentMesh{GetMesh()};
+    if (!IsValid(CurrentMesh))
+    {
+        return false;
+    }
+
+    const FString CurrentMeshPath(CurrentMesh->GetPathName());
+    const FString LeftHandDefaultMeshPath(GetDefaultLeftHandMeshPath());
+    const FString LeftHandDefaultMeshPathOnly(GetDefaultLeftHandMeshPathOnly());
+    const FString RightHandDefaultMeshPath(GetDefaultRightHandMeshPath());
+    const FString RightHandDefaultMeshPathOnly(GetDefaultRightHandMeshPathOnly());
+    if (CurrentMeshPath == LeftHandDefaultMeshPath
+        || CurrentMeshPath == LeftHandDefaultMeshPathOnly
+        || CurrentMeshPath == RightHandDefaultMeshPath
+        || CurrentMeshPath == RightHandDefaultMeshPathOnly)
+    {
+        return true;
+    }
+
+    return false;
+}
+
 bool USGVirtualHandComponent::FImpl::IsUsingUserMesh() const
 {
    const USkeletalMesh* CurrentMesh{GetMesh()};
@@ -555,7 +580,14 @@ USkeletalMesh* USGVirtualHandComponent::FImpl::LoadDefaultMesh() const

 void USGVirtualHandComponent::FImpl::SetDefaultMesh() const
 {
-    Owner->SetSkeletalMesh(LoadDefaultMesh(), true);
+    // FIXME
+    // Since we dont ship a default virtual hand mesh at the moment, calling SetDefaultMesh causes the following failed
+    // assertion due the fact that the engine won't be able to find the asset at the default location:
+    // Assertion failed: IsInGameThread()
+    // Unable to load /SenseGlove/Meshes/SK_SenseGlove_VirtualHand_*. Objects and Packages can only be loaded from the
+    // One workaround would be disabling the async loading or as an alternative simply disabling this portion of the
+    // code should be a good-enough fix until we address this issue in it's own time.
+    //Owner->SetSkeletalMesh(LoadDefaultMesh(), true);
 }

 USkeletalMesh* USGVirtualHandComponent::FImpl::GetMesh() const